[wrangler] Add one-time --force notice and drop skipped telemetry in Pages delegation#14601
Conversation
🦋 Changeset detectedLatest commit: a23f809 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Codeowners approval required for this PR:
Show detailed file reviewers |
|
✅ All changesets look good |
|
Everything looks correct and well-tested. Let me do a final check on the deploy.ts Let me also confirm that for One last consideration: the notice message is printed via The changes are logically sound, well-tested, and consistent with the codebase conventions. The telemetry removal is intentional and tests are updated accordingly. The LGTM |
@cloudflare/autoconfig
create-cloudflare
@cloudflare/deploy-helpers
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-auth
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
a4957f0 to
a23f809
Compare
…Pages delegation When an agent opts out of the Pages-to-Workers delegation with `--force`, Wrangler now prints an end-of-command notice (on success) explaining that `--force` only needs to be passed once, since the project then exists and subsequent commands are no longer delegated. Also stop emitting the `skipped` telemetry event: those are deterministic, expected non-cases (e.g. the account already has Pages projects) that carry no signal, and the count is derivable from the Pages command's own telemetry.
Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com>
a23f809 to
e7f9936
Compare
penalosa
left a comment
penalosa
left a comment
There was a problem hiding this comment.
Are we recording --force in the telemetry?
workers-devprod
left a comment
workers-devprod
left a comment
There was a problem hiding this comment.
Codeowners reviews satisfied
yes |
3 participants
Follow-up refinements to the Pages-to-Workers delegation shipped in #14312, based on early telemetry.
Two changes:
One-time
--forceguidance for agents. When an agent opts out of the delegation by passing--forcetowrangler pages deployorwrangler pages project create, Wrangler now prints an end-of-command notice (only on success) telling the agent that--forceonly needs to be passed once — the project now exists, so subsequent commands are no longer eligible for delegation and run against Pages directly without--force. This addresses agents repeatedly appending--forceafter learning about it from the delegation failure message.Stop emitting the
skippedtelemetry event. Skips are deterministic, expected non-cases (the account already has Pages projects, the project uses an unsupported Pages feature, Pages-only args are present, etc.), so the event carries no signal and dominated event volume. The count of skipped commands is derivable from the Pages command's own telemetry, so a dedicated event is not needed. Locallogger.debugoutput is retained for developer visibility.--forceopt-out and internal telemetry for an experimental feature; there is no user-facing documentation to update.